Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experiment: wgpu sync #13402

Merged
merged 16 commits into from
Jan 19, 2022
Merged

experiment: wgpu sync #13402

merged 16 commits into from
Jan 19, 2022

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Jan 17, 2022 •
edited
Loading

An experiment to streamline keeping our ext/webgpu in sync with upstream gfx-rs/wgpu

TODO

@AaronO AaronO requested a review from kitsonk as a code owner January 18, 2022 00:34
@AaronO AaronO self-assigned this Jan 18, 2022
bartlomieju
bartlomieju reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A README on how to upgrade these crates would be useful

@AaronO
Copy link
Contributor Author

AaronO commented Jan 18, 2022

A README on how to upgrade these crates would be useful

Simply:

  1. Change COMMIT in ./tools/wgpu_sync.js
  2. Run ./tools/wgpu_sync.js
  3. Double check changes, possibly patch

@bartlomieju
Copy link
Member

A README on how to upgrade these crates would be useful

Simply:

  1. Change COMMIT in ./tools/wgpu_sync.js
  2. Run ./tools/wgpu_sync.js
  3. Double check changes, possibly patch

Great, but if there's no README then it will be lost.

@AaronO
Copy link
Contributor Author

AaronO commented Jan 18, 2022

A README on how to upgrade these crates would be useful

Simply:

  1. Change COMMIT in ./tools/wgpu_sync.js
  2. Run ./tools/wgpu_sync.js
  3. Double check changes, possibly patch

Great, but if there's no README then it will be lost.

Yeah I'll add it, with some other polish. This started out mainly as an experiment to PoC it and avoid fragmenting deno_core and splitting it out of the repo if not necessary

@crowlKats crowlKats mentioned this pull request Jan 19, 2022
Closed
crowlKats
crowlKats approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just that README is missing

@AaronO AaronO merged commit 2ab21da into denoland:main Jan 19, 2022
@AaronO AaronO deleted the experiment/wgpu-sync branch January 19, 2022 12:38
AaronO added a commit to AaronO/deno that referenced this pull request Jan 20, 2022
@AaronO
revert: experiment: wgpu sync (denoland#13402)
22c1fdb
AaronO added a commit that referenced this pull request Jan 20, 2022
@AaronO
revert(#13402): experiment: wgpu sync (#13439)
3ab68bd
@AaronO AaronO mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@crowlKats crowlKats crowlKats approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

@dsherret dsherret Awaiting requested review from dsherret

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

@kitsonk kitsonk Awaiting requested review from kitsonk

Assignees

@AaronO AaronO

@crowlKats crowlKats

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AaronO @bartlomieju @crowlKats